pgsql: Preserve CurrentMemoryContext across notify and sinval interrupt
От | Tom Lane |
---|---|
Тема | pgsql: Preserve CurrentMemoryContext across notify and sinval interrupt |
Дата | |
Msg-id | E1sOJmS-003oJa-1P@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Preserve CurrentMemoryContext across notify and sinval interrupts. ProcessIncomingNotify is called from the main processing loop that normally runs in MessageContext. That outer-loop code assumes that whatever it allocates will be cleaned up when we're done processing the current client message --- but if we service a notify interrupt, then whatever gets allocated before the next switch into MessageContext will be permanently leaked in TopMemoryContext, because CommitTransactionCommand sets CurrentMemoryContext to TopMemoryContext. There are observable leaks associated with (at least) encoding conversion of incoming queries and parameters attached to Bind messages. sinval catchup interrupts have a similar problem. There might be others, but I've not identified any other clear cases. To fix, take care to save and restore CurrentMemoryContext across the Start/CommitTransactionCommand calls in these functions. Per bug #18512 from wizardbrony. Commit to back branches only; in HEAD, this was dealt with by the riskier but more thoroughgoing approach in commit 1afe31f03. Discussion: https://postgr.es/m/3478884.1718656625@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8565fb6fbb6908b6af0ad2035820cb7578f9bcb8 Modified Files -------------- src/backend/commands/async.c | 11 ++++++++++- src/backend/storage/ipc/sinval.c | 7 +++++++ 2 files changed, 17 insertions(+), 1 deletion(-)
В списке pgsql-committers по дате отправления: