[MASSMAIL] pgsql: Further review for re-implementation of psql's FETCH_COUNT featu

Поиск
Список
Период
Сортировка
От Tom Lane
Тема [MASSMAIL] pgsql: Further review for re-implementation of psql's FETCH_COUNT featu
Дата
Msg-id E1rtuzU-001B8P-OK@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Further review for re-implementation of psql's FETCH_COUNT feature.

Alexander Lakhin noted an obsolete comment, which led me to revisit
some other important comments in the patch, and that study turned up a
couple of unintended ways in which the chunked-fetch code path didn't
match the normal code path in ExecQueryAndProcessResults.  The only
nontrivial problem is that it didn't call PrintQueryStatus, so that
we'd not print the final status result from DML ... RETURNING
commands.  To avoid code duplication, move the filter for whether a
result is from RETURNING from PrintQueryResult to PrintQueryStatus.

Discussion: https://postgr.es/m/0023bea5-79c0-476e-96c8-dad599cc3ad8@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c21d4c416ad61b78cf450f11861bbafbdfb7eebc

Modified Files
--------------
src/bin/psql/common.c | 78 ++++++++++++++++++++++++++++++++-------------------
1 file changed, 49 insertions(+), 29 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Teach radix tree to embed values at runtime
Следующее
От: Tom Lane
Дата:
Сообщение: [MASSMAIL]pgsql: In psql, avoid leaking a PGresult after a query is cancelled.