pgsql: Turn tail recursion into iteration in CommitTransactionCommand()

Поиск
Список
Период
Сортировка
От Alexander Korotkov
Тема pgsql: Turn tail recursion into iteration in CommitTransactionCommand()
Дата
Msg-id E1riYFt-002i19-TD@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Turn tail recursion into iteration in CommitTransactionCommand()

Usually the compiler will optimize away the tail recursion anyway, but
if it doesn't, you can drive the function into stack overflow. For
example:

    (n=1000000; printf "BEGIN;"; for ((i=1;i<=$n;i++)); do printf "SAVEPOINT s$i;"; done; printf "ERROR; COMMIT;") |
psql>/dev/null 

In order to get better readability and less changes to the existing code the
recursion-replacing loop is implemented as a wrapper function.

Report by Egor Chindyaskin and Alexander Lakhin.
Discussion: https://postgr.es/m/1672760457.940462079%40f306.i.mail.ru
Author: Alexander Korotkov, Heikki Linnakangas

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fefd9a3fed275cecd9ed4091b00698deed39b92e

Modified Files
--------------
src/backend/access/transam/xact.c | 151 ++++++++++++++++++++++++++------------
1 file changed, 106 insertions(+), 45 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: pgsql: Unicode case mapping tables and functions.
Следующее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Admit deferrable PKs into rd_pkindex, but flag them as such