pgsql: Compute aggregate argument types correctly in transformAggregate
От | Tom Lane |
---|---|
Тема | pgsql: Compute aggregate argument types correctly in transformAggregate |
Дата | |
Msg-id | E1r01g7-004C21-V2@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Compute aggregate argument types correctly in transformAggregateCall(). transformAggregateCall() captures the datatypes of the aggregate's arguments immediately to construct the Aggref.aggargtypes list. This seems reasonable because the arguments have already been transformed --- but there is an edge case where they haven't been. Specifically, if we have an unknown-type literal in an ANY argument position, nothing will have been done with it earlier. But if we also have DISTINCT, then addTargetToGroupList() converts the literal to "text" type, resulting in the aggargtypes list not matching the actual runtime type of the argument. The end result is that the aggregate tries to interpret a "text" value as being of type "unknown", that is a zero-terminated C string. If the text value contains no zero bytes, this could result in disclosure of server memory following the text literal value. To fix, move the collection of the aggargtypes list to the end of transformAggregateCall(), after DISTINCT has been handled. This requires slightly more code, but not a great deal. Our thanks to Jingzhou Fu for reporting this problem. Security: CVE-2023-5868 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4f4a422fbb15e49ff5e9dc410cd8713d63fdda24 Modified Files -------------- src/backend/parser/parse_agg.c | 35 +++++++++++++++++++++++------------ src/test/regress/expected/jsonb.out | 7 +++++++ src/test/regress/sql/jsonb.sql | 3 +++ 3 files changed, 33 insertions(+), 12 deletions(-)
В списке pgsql-committers по дате отправления: