pgsql: Fix checking of index expressions in CompareIndexInfo().

Fix checking of index expressions in CompareIndexInfo().

This code was sloppy about comparison of index columns that
are expressions.  It didn't reliably reject cases where one
index has an expression where the other has a plain column,
and it could index off the start of the attmap array, leading
to a Valgrind complaint (though an actual crash seems unlikely).

I'm not sure that the expression-vs-column sloppiness leads
to any visible problem in practice, because the subsequent
comparison of the two expression lists would reject cases
where the indexes have different numbers of expressions
overall.  Maybe we could falsely match indexes having the
same expressions in different column positions, but it'd
require unlucky contents of the word before the attmap array.
It's not too surprising that no problem has been reported
from the field.  Nonetheless, this code is clearly wrong.

Per bug #18135 from Alexander Lakhin.  Back-patch to all
supported branches.

Discussion: https://postgr.es/m/18135-532f4a755e71e4d2@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9f71e10d65fa2db7cde9fe1554f89a9526904eb9

Modified Files
--------------
src/backend/catalog/index.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)