pgsql: Remove unnecessary checks for indexes for REPLICA IDENTITY FULL

Поиск
Список
Период
Сортировка
От Masahiko Sawada
Тема pgsql: Remove unnecessary checks for indexes for REPLICA IDENTITY FULL
Дата
Msg-id E1qOBIA-001ETQ-CC@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Remove unnecessary checks for indexes for REPLICA IDENTITY FULL tables.

Previously, when selecting an usable index for update/delete for the
REPLICA IDENTITY FULL table, in IsIndexOnlyExpression(), we used to
check if all index fields are not expressions. However, it was not
necessary, because it is enough to check if only the leftmost index
field is not an expression (and references the remote table column)
and this check has already been done by
RemoteRelContainsLeftMostColumnOnIdx().

This commit removes IsIndexOnlyExpression() and
RemoteRelContainsLeftMostColumnOnIdx() and all checks for usable
indexes for REPLICA IDENTITY FULL tables are now performed by
IsIndexUsableForReplicaIdentityFull().

Backpatch this to remain the code consistent.

Reported-by: Peter Smith
Reviewed-by: Amit Kapila, Önder Kalacı
Discussion: https://postgr.es/m/CAHut%2BPsGRE5WSsY0jcLHJEoA17MrbP9yy8FxdjC_ZOAACxbt%2BQ%40mail.gmail.com
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/35c85c3c9b90eb70937c8f409d2e7615b2bdb538

Modified Files
--------------
src/backend/executor/execReplication.c     |   9 --
src/backend/replication/logical/relation.c | 128 ++++++++++++-----------------
src/backend/replication/logical/worker.c   |  24 ++++--
src/include/replication/logicalrelation.h  |   2 +-
4 files changed, 73 insertions(+), 90 deletions(-)


В списке pgsql-committers по дате отправления: