pgsql: Correctly update hasSubLinks while mutating a rule action.
От | Tom Lane |
---|---|
Тема | pgsql: Correctly update hasSubLinks while mutating a rule action. |
Дата | |
Msg-id | E1q9AAc-001dun-KL@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Correctly update hasSubLinks while mutating a rule action. rewriteRuleAction neglected to check for SubLink nodes in the securityQuals of range table entries. This could lead to failing to convert such a SubLink to a SubPlan, resulting in assertion crashes or weird errors later in planning. In passing, fix some poor coding in rewriteTargetView: we should not pass the source parsetree's hasSubLinks field to ReplaceVarsFromTargetList's outer_hasSubLinks. ReplaceVarsFromTargetList knows enough to ignore that when a Query node is passed, but it's still confusing and bad precedent: if we did try to update that flag we'd be updating a stale copy of the parsetree. Per bug #17972 from Alexander Lakhin. This has been broken since we added RangeTblEntry.securityQuals (although the presented test case only fails back to 215b43cdc), so back-patch all the way. Discussion: https://postgr.es/m/17972-f422c094237847d0@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b4110bdbfe9d3cede772e1f37f9a7467e63e158b Modified Files -------------- src/backend/rewrite/rewriteHandler.c | 4 +++- src/test/regress/expected/updatable_views.out | 32 +++++++++++++++++++++++++++ src/test/regress/sql/updatable_views.sql | 17 ++++++++++++++ 3 files changed, 52 insertions(+), 1 deletion(-)
В списке pgsql-committers по дате отправления: