pgsql: Advance input pointer when LZ4 compressing data

Поиск
Список
Период
Сортировка
От Tomas Vondra
Тема pgsql: Advance input pointer when LZ4 compressing data
Дата
Msg-id E1pzIeC-000Lpb-8L@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Advance input pointer when LZ4 compressing data

LZ4File_write() did not advance the input pointer on subsequent invocations of
LZ4F_compressUpdate(). As a result the generated compressed output would be a
compressed version of the same input chunk.

Tests failed to catch this error because the data would comfortably fit
within the default buffer size, as a single chunk. Tests have been added
to provide adequate coverage of multi-chunk compression.

WriteDataToArchiveLZ4() which is also using LZ4F_compressUpdate() did
not suffer from this omission.

Author: Georgios Kokolatos <gkokolatos@pm.me>
Reported-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/ZFhCyn4Gm2eu60rB%40paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a05c1d252993b0a59c58a6daf91a2df9333044f

Modified Files
--------------
src/bin/pg_dump/compress_io.h    |  8 ++++++-
src/bin/pg_dump/compress_lz4.c   |  2 ++
src/bin/pg_dump/t/002_pg_dump.pl | 46 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 1 deletion(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Thom Brown
Дата:
Сообщение: Re: pgsql: Null-terminate the output buffer of LZ4Stream_gets
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Convert nullingrels match checks from Asserts to test-and-elog.