pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression
От | Tom Lane |
---|---|
Тема | pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression |
Дата | |
Msg-id | E1pr0nD-004iNU-3C@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix memory leakage in plpgsql DO blocks that use cast expressions. Commit 04fe805a1 modified plpgsql so that datatype casts make use of expressions cached by plancache.c, in place of older code where these expression trees were managed by plpgsql itself. However, I (tgl) forgot that we use a separate, shorter-lived cast info hashtable in DO blocks. The new mechanism thus resulted in session-lifespan leakage of the plancache data once a DO block containing one or more casts terminated. To fix, split the cast hash table into two parts, one that tracks only the plancache's CachedExpressions and one that tracks the expression state trees generated from them. DO blocks need their own expression state trees and hence their own version of the second hash table, but there's no reason they can't share the CachedExpressions with regular plpgsql functions. Per report from Ajit Awekar. Back-patch to v12 where the issue was introduced. Ajit Awekar and Tom Lane Discussion: https://postgr.es/m/CAHv6PyrNaqdvyWUspzd3txYQguFTBSnhx+m6tS06TnM+KWc_LQ@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bfa691087eacc6e0fbf1a0d8ee392c3d2ff3cb34 Modified Files -------------- src/pl/plpgsql/src/pl_exec.c | 95 ++++++++++++++++++++++++++++++-------------- src/pl/plpgsql/src/plpgsql.h | 2 +- 2 files changed, 67 insertions(+), 30 deletions(-)
В списке pgsql-committers по дате отправления: