pgsql: Skip the 004_io_direct.pl test if a pre-flight check fails.

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема pgsql: Skip the 004_io_direct.pl test if a pre-flight check fails.
Дата
Msg-id E1pmmH7-002n2B-AY@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Skip the 004_io_direct.pl test if a pre-flight check fails.

The test previously had a list of OSes that direct I/O was expected to
work on.  That worked well enough for the systems in our build farm, but
didn't survive contact with the Debian build bots running on tmpfs via
overlayfs.  tmpfs does not support O_DIRECT, but we don't want to
exclude Linux generally.

The new approach is to try to create an empty file with O_DIRECT from
Perl first.  If that fails, we'll skip the test and report what the
error was.

Reported-by: Christoph Berg <myon@debian.org>
Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/ZDYd4A78cT2ULxZZ%40msg.df7cb.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ca8df2d61473327b0e90b9becfe109299f47b8a

Modified Files
--------------
src/test/modules/test_misc/t/004_io_direct.pl | 35 +++++++++++++++++++++------
1 file changed, 27 insertions(+), 8 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: pgsql: Remove overzealous assertion from PHJ.
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Add missing XML ID attribute