pgsql: Fix detection of unseekable files for fseek() and ftello() with
От | Michael Paquier |
---|---|
Тема | pgsql: Fix detection of unseekable files for fseek() and ftello() with |
Дата | |
Msg-id | E1pmO4b-002cLp-PD@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix detection of unseekable files for fseek() and ftello() with MSVC Calling fseek() or ftello() on a handle to a non-seeking device such as a pipe or a communications device is not supported. Unfortunately, MSVC's flavor of these routines, _fseeki64() and _ftelli64(), do not return an error when given a pipe as handle. Some of the logic of pg_dump and restore relies on these routines to check if a handle is seekable, causing failures when passing the contents of pg_dump to pg_restore through a pipe, for example. This commit introduces wrappers for fseeko() and ftello() on MSVC so as any callers are able to properly detect the cases of non-seekable handles. This relies mainly on GetFileType(), sharing a bit of code with the MSVC port for fstat(). The code in charge of getting a file type is refactored into a new file called win32common.c, shared by win32stat.c and the new win32fseek.c. It includes the MSVC ports for fseeko() and ftello(). Like 765f5df, this is backpatched down to 14, where the fstat() implementation for MSVC is able to understand about files larger than 4GB in size. Using a TAP test for that is proving to be tricky as IPC::Run handles the pipes by itself, still I have been able to check the fix manually. Reported-by: Daniel Watzinger Author: Juan José Santamaría Flecha, Michael Paquier Discussion: https://postgr.es/m/CAC+AXB26a4EmxM2suXxPpJaGrqAdxracd7hskLg-zxtPB50h7A@mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/34105eea62e1a607a30596840c7e6dd1cd3feb14 Modified Files -------------- configure | 6 ++++ configure.ac | 1 + src/include/port/win32_port.h | 12 +++++-- src/port/win32common.c | 68 +++++++++++++++++++++++++++++++++++++++ src/port/win32fseek.c | 75 +++++++++++++++++++++++++++++++++++++++++++ src/port/win32stat.c | 22 ++----------- src/tools/msvc/Mkvcbuild.pm | 3 +- 7 files changed, 164 insertions(+), 23 deletions(-)
В списке pgsql-committers по дате отправления: