pgsql: pgbench: Prepare commands in pipelines in advance
От | Alvaro Herrera |
---|---|
Тема | pgsql: pgbench: Prepare commands in pipelines in advance |
Дата | |
Msg-id | E1pUPg7-002FW9-FF@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
pgbench: Prepare commands in pipelines in advance Failing to do so results in an error when a pgbench script tries to start a serializable transaction inside a pipeline, because by the time BEGIN ISOLATION LEVEL SERIALIZABLE is executed, we're already in a transaction that has acquired a snapshot, so the server rightfully complains. We can work around that by preparing all commands in the pipeline before actually starting the pipeline. This changes the existing code in two aspects: first, we now prepare each command individually at the point where that command is about to be executed; previously, we would prepare all commands in a script as soon as the first command of that script would be executed. It's hard to see that this would make much of a difference (particularly since it only affects the first time to execute each script in a client), but I didn't actually try to measure it. Secondly, we no longer use PQsendPrepare() in pipeline mode, but only PQprepare. There's no specific reason for this change other than no longer needing to do differently in pipeline mode. (Previously we had no choice, because in pipeline mode PQprepare could not be used.) Backpatch to 14, where pgbench got support for pipeline mode. Reported-by: Yugo NAGATA <nagata@sraoss.co.jp> Discussion: https://postgr.es/m/20210716153013.fc53b1c780b06fccc07a7f0d@sraoss.co.jp Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/108a22bd14d4deb98340deec422cfec6d3b37840 Modified Files -------------- src/bin/pgbench/pgbench.c | 159 ++++++++++++++++++--------- src/bin/pgbench/t/001_pgbench_with_server.pl | 20 ++++ 2 files changed, 127 insertions(+), 52 deletions(-)
В списке pgsql-committers по дате отправления: