pgsql: Fix DEFAULT handling for multi-row INSERT rules.
От | Dean Rasheed |
---|---|
Тема | pgsql: Fix DEFAULT handling for multi-row INSERT rules. |
Дата | |
Msg-id | E1p1Rf6-001pfm-N9@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix DEFAULT handling for multi-row INSERT rules. When updating a relation with a rule whose action performed an INSERT from a multi-row VALUES list, the rewriter might skip processing the VALUES list, and therefore fail to replace any DEFAULTs in it. This would lead to an "unrecognized node type" error. The reason was that RewriteQuery() assumed that a query doing an INSERT from a multi-row VALUES list would necessarily only have one item in its fromlist, pointing to the VALUES RTE to read from. That assumption is correct for the original query, but not for product queries produced for rule actions. In such cases, there may be multiple items in the fromlist, possibly including multiple VALUES RTEs. What is required instead is for RewriteQuery() to skip any RTEs from the product query's originating query, which might include one or more already-processed VALUES RTEs. What's left should then include at most one VALUES RTE (from the rule action) to be processed. Patch by me. Thanks to Tom Lane for reviewing. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAEZATCV39OOW7LAR_Xq4i%2BLc1Byux%3DeK3Q%3DHD_pF1o9LBt%3DphA%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2c7ed9f752924c038abffb46999a0f543139d797 Modified Files -------------- src/backend/rewrite/rewriteHandler.c | 47 +++++++++++++++---- src/test/regress/expected/rules.out | 91 ++++++++++++++++++++---------------- src/test/regress/sql/rules.sql | 15 +++--- 3 files changed, 99 insertions(+), 54 deletions(-)
В списке pgsql-committers по дате отправления: