pgsql: Prevent port collisions between concurrent TAP tests
От | Andrew Dunstan |
---|---|
Тема | pgsql: Prevent port collisions between concurrent TAP tests |
Дата | |
Msg-id | E1oxVda-000NI7-N2@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Prevent port collisions between concurrent TAP tests Currently there is a race condition where if concurrent TAP tests both test that they can open a port they will assume that it is free and use it, causing one of them to fail. To prevent this we record a reservation using an exclusive lock, and any TAP test that discovers a reservation checks to see if the reserving process is still alive, and looks for another free port if it is. Ports are reserved in a directory set by the environment setting PG_TEST_PORT_DIR, or if that doesn't exist a subdirectory of the top build directory as set by Makefile.global, or its own tmp_check directory. The prove_check recipe in Makefile.global.in is extended to export top_builddir to the TAP tests. This was already exported by the prove_installcheck recipes. Per complaint from Andres Freund Backpatched from 9b4eafcaf4 to all live branches Discussion: https://postgr.es/m/20221002164931.d57hlutrcz4d2zi7@awork3.anarazel.de Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4b9013d64f231ddbadd2b06cf75499c8e8cd4cc1 Modified Files -------------- src/Makefile.global.in | 1 + src/test/perl/PostgresNode.pm | 64 +++++++++++++++++++++++++++++++++++++++---- 2 files changed, 60 insertions(+), 5 deletions(-)
В списке pgsql-committers по дате отправления: