pgsql: Rename parser token REF to REF_P to avoid a symbol conflict.
От | Tom Lane |
---|---|
Тема | pgsql: Rename parser token REF to REF_P to avoid a symbol conflict. |
Дата | |
Msg-id | E1ok9NW-002f9e-I9@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Rename parser token REF to REF_P to avoid a symbol conflict. In the latest version of Apple's macOS SDK, <sys/socket.h> fails to compile if "REF" is #define'd as something. Apple may or may not agree that this is a bug, and even if they do accept the bug report I filed, they probably won't fix it very quickly. In the meantime, our back branches will all fail to compile gram.y. v15 and HEAD currently escape the problem thanks to the refactoring done in 98e93a1fc, but that's purely accidental. Moreover, since that patch removed a widely-visible inclusion of <netdb.h>, back-patching it seems too likely to break third-party code. Instead, change the token's code name to REF_P, following our usual convention for naming parser tokens that are likely to have symbol conflicts. The effects of that should be localized to the grammar and immediately surrounding files, so it seems like a safer answer. Per project policy that we want to keep recently-out-of-support branches buildable on modern systems, back-patch all the way to 9.2. Discussion: https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6618c276b7a0a8a9373789efc3e35c886f3d3490 Modified Files -------------- src/backend/parser/gram.y | 10 +++++----- src/include/parser/kwlist.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-)
В списке pgsql-committers по дате отправления: