pgsql: windows: Adjust FD_SETSIZE via commandline define
От | Andres Freund |
---|---|
Тема | pgsql: windows: Adjust FD_SETSIZE via commandline define |
Дата | |
Msg-id | E1ogXCU-001Cth-Hq@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
windows: Adjust FD_SETSIZE via commandline define When using precompiled headers, we cannot pre-define macros for the system headers from within .c files, as headers are already processed before the #define in the C file is reached. But we can pre-define using -DFD_SETSIZE, as long as that's also used when building the precompiled header. A few files #define FD_SETSIZE 1024 on windows, as the default is only 64. I am hesitant to change FD_SETSIZE globally on windows, due to src/backend/port/win32/socket.c using it to size on-stack arrays. Instead add -DFD_SETSIZE=1024 when building the specific targets needing it. We likely should move away from using select() in those places, but that's a larger change. Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com> Reviewed-by: Justin Pryzby <pryzby@telsasoft.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de Discussion: https://postgr.es/m/CA+hUKG+50eOUbN++ocDc0Qnp9Pvmou23DSXu=ZA6fepOcftKqA@mail.gmail.com Discussion: https://postgr.es/m/20190826054000.GE7005%40paquier.xyz Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4289263cf263ba36e474728f4a02ceb086903f81 Modified Files -------------- src/bin/pgbench/Makefile | 2 ++ src/bin/pgbench/meson.build | 1 + src/bin/pgbench/pgbench.c | 4 ++-- src/fe_utils/Makefile | 4 ++++ src/fe_utils/meson.build | 1 + src/fe_utils/parallel_slot.c | 4 ++-- src/tools/msvc/Mkvcbuild.pm | 27 +++++++++++++++++++-------- 7 files changed, 31 insertions(+), 12 deletions(-)
В списке pgsql-committers по дате отправления: