pgsql: Rename shadowed local variables

Rename shadowed local variables

In a similar effort to f01592f91, here we mostly rename shadowed local
variables to remove the warnings produced when compiling with
-Wshadow=compatible-local.

This fixes 63 warnings and leaves just 5.

Author: Justin Pryzby, David Rowley
Reviewed-by: Justin Pryzby
Discussion https://postgr.es/m/20220817145434.GC26426%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2d0bbedda7c4fbf7092c39b0c06b56cb238e15d7

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c     |  8 ++--
src/backend/access/gin/ginget.c                 |  6 +--
src/backend/access/heap/heapam.c                | 18 ++++-----
src/backend/access/transam/clog.c               | 30 +++++++-------
src/backend/backup/basebackup.c                 |  8 ++--
src/backend/catalog/heap.c                      | 16 ++++----
src/backend/catalog/namespace.c                 | 12 ++----
src/backend/commands/publicationcmds.c          |  6 +--
src/backend/commands/tablecmds.c                | 22 +++++------
src/backend/commands/trigger.c                  |  4 +-
src/backend/executor/nodeAgg.c                  | 11 ++----
src/backend/executor/spi.c                      | 26 ++++++-------
src/backend/optimizer/path/costsize.c           |  4 +-
src/backend/optimizer/path/indxpath.c           |  6 +--
src/backend/optimizer/path/tidpath.c            |  6 +--
src/backend/optimizer/plan/planner.c            | 12 +++---
src/backend/optimizer/prep/prepunion.c          |  5 ++-
src/backend/optimizer/util/clauses.c            | 10 ++---
src/backend/optimizer/util/paramassign.c        | 16 ++++----
src/backend/parser/parse_clause.c               |  6 +--
src/backend/partitioning/partbounds.c           |  6 +--
src/backend/partitioning/partprune.c            |  5 +--
src/backend/replication/logical/reorderbuffer.c | 10 ++---
src/backend/replication/walreceiver.c           |  6 +--
src/backend/statistics/dependencies.c           |  7 ++--
src/backend/storage/lmgr/lock.c                 | 10 ++---
src/backend/storage/lmgr/proc.c                 | 27 ++++++-------
src/backend/tsearch/ts_typanalyze.c             |  8 ++--
src/backend/utils/adt/array_typanalyze.c        |  6 +--
src/backend/utils/adt/datetime.c                | 52 ++++++++++++-------------
src/backend/utils/adt/numutils.c                |  6 +--
src/backend/utils/adt/partitionfuncs.c          |  4 +-
src/backend/utils/adt/ruleutils.c               |  4 +-
src/bin/psql/command.c                          | 14 +++----
src/include/lib/simplehash.h                    |  8 ++--
src/interfaces/ecpg/ecpglib/execute.c           |  6 +--
src/interfaces/ecpg/ecpglib/misc.c              |  2 +-
src/interfaces/ecpg/pgtypeslib/dt_common.c      | 26 ++++++-------
src/pl/plpgsql/src/pl_funcs.c                   |  7 ++--
39 files changed, 220 insertions(+), 226 deletions(-)