pgsql: Remove ALL keyword from TABLES IN SCHEMA for publication
От | Alvaro Herrera |
---|---|
Тема | pgsql: Remove ALL keyword from TABLES IN SCHEMA for publication |
Дата | |
Msg-id | E1obPhv-001X12-Uw@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Remove ALL keyword from TABLES IN SCHEMA for publication This may be a bit too subtle, but removing that word from there makes this clause no longer a perfect parallel of the GRANT variant "ALL TABLES IN SCHEMA": indeed, for publications what we record is the schema itself, not the tables therein, which means that any tables added to the schema in the future are also published. This is completely different to what GRANT does, which is affect only the tables that exist when the command is executed. There isn't resounding support for this change, but there are a few positive votes and no opposition. Because the time to 15 RC1 is very short, let's get this out now. Backpatch to 15. Discussion: https://postgr.es/m/2729c9e2-9aac-8cda-f2f4-34f2bcc18f4e Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/790bf615ddba8a0ba3b870915d03438ce9cb7860 Modified Files -------------- doc/src/sgml/logical-replication.sgml | 4 +- doc/src/sgml/ref/alter_publication.sgml | 16 +-- doc/src/sgml/ref/create_publication.sgml | 14 +-- doc/src/sgml/ref/create_subscription.sgml | 2 +- doc/src/sgml/system-views.sgml | 2 +- src/backend/catalog/pg_publication.c | 4 +- src/backend/commands/publicationcmds.c | 6 +- src/backend/parser/gram.y | 18 ++-- src/backend/replication/pgoutput/pgoutput.c | 3 +- src/bin/pg_dump/pg_dump.c | 2 +- src/bin/pg_dump/t/002_pg_dump.pl | 15 ++- src/bin/psql/tab-complete.c | 15 ++- src/test/regress/expected/alter_table.out | 2 +- src/test/regress/expected/object_address.out | 2 +- src/test/regress/expected/publication.out | 120 ++++++++++----------- src/test/regress/sql/alter_table.sql | 2 +- src/test/regress/sql/object_address.sql | 2 +- src/test/regress/sql/publication.sql | 104 +++++++++--------- .../subscription/t/025_rep_changes_for_schema.pl | 6 +- src/test/subscription/t/028_row_filter.pl | 12 +-- src/test/subscription/t/031_column_list.pl | 4 +- 21 files changed, 176 insertions(+), 179 deletions(-)
В списке pgsql-committers по дате отправления: