pgsql: postgres_fdw: Disable batch insertion when there are WCO constra

Поиск
Список
Период
Сортировка
От Etsuro Fujita
Тема pgsql: postgres_fdw: Disable batch insertion when there are WCO constra
Дата
Msg-id E1oJshM-000Os5-9t@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
postgres_fdw: Disable batch insertion when there are WCO constraints.

When inserting a view referencing a foreign table that has WITH CHECK
OPTION constraints, in single-insert mode postgres_fdw retrieves the
data that was actually inserted on the remote side so that the WITH
CHECK OPTION constraints are enforced with the data locally, but in
batch-insert mode it cannot currently retrieve the data (except for the
row first inserted through the view), resulting in enforcing the WITH
CHECK OPTION constraints with the data passed from the core (except for
the first-inserted row), which led to incorrect results when inserting
into a view referencing a foreign table in which a remote BEFORE ROW
INSERT trigger changes the rows inserted through the view so that they
violate the view's WITH CHECK OPTION constraint.  Also, the query
inserting into the view caused an assertion failure in assert-enabled
builds.

Fix these by disabling batch insertion when inserting into such a view.

Back-patch to v14 where batch insertion was added.

Discussion: https://postgr.es/m/CAPmGK17LpbTZs4m4a_6THP54UBeK9fHvX8aVVA%2BC6yEZDZwQcg%40mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4a9bc2e0f5226d29e7e11c9611b8649a4aa74a4b

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 44 ++++++++++++++++++++++++++
contrib/postgres_fdw/postgres_fdw.c            |  6 ++--
contrib/postgres_fdw/sql/postgres_fdw.sql      | 16 ++++++++++
3 files changed, 64 insertions(+), 2 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Fix ENABLE/DISABLE TRIGGER to handle recursion correctly
Следующее
От: John Naylor
Дата:
Сообщение: pgsql: Simplify coding style of is_valid_ascii()