pgsql: Be more careful about GucSource for internally-driven GUC settin
От | Tom Lane |
---|---|
Тема | pgsql: Be more careful about GucSource for internally-driven GUC settin |
Дата | |
Msg-id | E1nyzRn-003KdB-Md@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Be more careful about GucSource for internally-driven GUC settings. The original advice for hard-wired SetConfigOption calls was to use PGC_S_OVERRIDE, particularly for PGC_INTERNAL GUCs. However, that's really overkill for PGC_INTERNAL GUCs, since there is no possibility that we need to override a user-provided setting. Instead use PGC_S_DYNAMIC_DEFAULT in most places, so that the value will appear with source = 'default' in pg_settings and thereby not be shown by psql's new \dconfig command. The one exception is that when changing in_hot_standby in a hot-standby session, we still use PGC_S_OVERRIDE, because people felt that seeing that in \dconfig would be a good thing. Similarly use PGC_S_DYNAMIC_DEFAULT for the auto-tune value of wal_buffers (if possible, that is if wal_buffers wasn't explicitly set to -1), and for the typical 2MB value of max_stack_depth. In combination these changes remove four not-very-interesting entries from the typical output of \dconfig, all of which people fingered as "why is that showing up?" in the discussion thread. Discussion: https://postgr.es/m/3118455.1649267333@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7ab5b4eb483478bc85ad45ef5405b4a70c3f4c94 Modified Files -------------- src/backend/access/transam/xlog.c | 15 ++++++++++++--- src/backend/bootstrap/bootstrap.c | 2 +- src/backend/postmaster/postmaster.c | 2 +- src/backend/storage/ipc/ipci.c | 6 ++++-- src/backend/utils/init/miscinit.c | 6 +++--- src/backend/utils/init/postinit.c | 6 +++--- src/backend/utils/misc/guc-file.l | 5 ++--- src/backend/utils/misc/guc.c | 34 ++++++++++++++++++++-------------- src/include/utils/guc.h | 8 ++++++-- 9 files changed, 52 insertions(+), 32 deletions(-)
В списке pgsql-committers по дате отправления: