Fix incorrect logic in HaveRegisteredOrActiveSnapshot().
This function gave the wrong answer when there's more than one
RegisteredSnapshots entry, whether or not any of them is the
CatalogSnapshot. This leads to assertion failure in some scenarios
involving fetching toasted data using a cursor. (As per discussion,
I'm dubious that this is the right contract to be enforcing at all;
but it surely doesn't help to be enforcing it incorrectly.)
Fetching toasted data using a cursor is evidently under-tested,
so add a test case too.
Per report from Erik Rijkers. This is new code, so no need for
back-patch.
Discussion: https://postgr.es/m/dc9dd229-ed30-6c62-4c41-d733ffff776b@xs4all.nl
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9f4f0a0dad4c7422a97d94e4051c08ec6d181dd6
Modified Files
--------------
src/backend/utils/time/snapmgr.c | 6 +++---
src/test/regress/expected/portals.out | 25 +++++++++++++++++++++++++
src/test/regress/sql/portals.sql | 24 ++++++++++++++++++++++++
3 files changed, 52 insertions(+), 3 deletions(-)