pgsql: Fix row filters with multiple publications
От | Tomas Vondra |
---|---|
Тема | pgsql: Fix row filters with multiple publications |
Дата | |
Msg-id | E1nUsch-0008rQ-FW@gemulon.postgresql.org обсуждение исходный текст |
Ответы |
Re: pgsql: Fix row filters with multiple publications
|
Список | pgsql-committers |
Fix row filters with multiple publications When publishing changes through a artition root, we should use the row filter for the top-most ancestor. The relation may be added to multiple publications, using different ancestors, and 52e4f0cd47 handled this incorrectly. With c91f71b9dc we find the correct top-most ancestor, but the code tried to fetch the row filter from all publications, including those using a different ancestor etc. No row filter can be found for such publications, which was treated as replicating all rows. Similarly to c91f71b9dc, this seems to be a rare issue in practice. It requires multiple publications including the same partitioned relation, through different ancestors. Fixed by only passing publications containing the top-most ancestor to pgoutput_row_filter_init(), so that treating a missing row filter as replicating all rows is correct. Report and fix by me, test case by Hou zj. Reviews and improvements by Amit Kapila. Author: Tomas Vondra, Hou zj, Amit Kapila Reviewed-by: Amit Kapila, Hou zj Discussion: https://postgr.es/m/d26d24dd-2fab-3c48-0162-2b7f84a9c893%40enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5a079662256e381fde699c4fbbed6c2504a6d30a Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 26 +++++++++++++--- src/test/subscription/t/028_row_filter.pl | 47 ++++++++++++++++++++++++++++- 2 files changed, 67 insertions(+), 6 deletions(-)
В списке pgsql-committers по дате отправления: