pgsql: Set SNI ClientHello extension to localhost in tests

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема pgsql: Set SNI ClientHello extension to localhost in tests
Дата
Msg-id E1nI9VR-0004sW-J9@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Set SNI ClientHello extension to localhost in tests

The connection strings in the SSL client tests were using the host
set up from Cluster.pm which is a temporary pathname. When SNI is
enabled we pass the host to OpenSSL in order to set the server name
indication ClientHello extension via SSL_set_tlsext_host_name.

OpenSSL doesn't validate the hostname apart from checking the max
length, but LibreSSL checks for RFC 5890 conformance which results
in errors during testing as the pathname from Cluster.pm is not a
valid hostname.

Fix by setting the host explicitly to localhost, as that's closer
to the intent of the test.

Backpatch through 14 where SNI support came in.

Reported-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/17391-304f81bcf724b58b@postgresql.org
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6d503d2a47324c15c5b4274bf4dd016064143754

Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 6 +++---
src/test/ssl/t/002_scram.pl    | 6 +++---
src/test/ssl/t/003_sslinfo.pl  | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Remove unnecessary resetPQExpBuffer call
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: pgsql: Set SNI ClientHello extension to localhost in tests