pgsql: Fix race condition in gettext() initialization in libpq and ecpg
От | Tom Lane |
---|---|
Тема | pgsql: Fix race condition in gettext() initialization in libpq and ecpg |
Дата | |
Msg-id | E1nB0eK-0003Mp-II@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix race condition in gettext() initialization in libpq and ecpglib. In libpq and ecpglib, multiple threads can concurrently enter the initialization logic for message localization. Since we set the its-done flag before actually doing the work, it'd be possible for some threads to reach gettext() before anyone has called bindtextdomain(). Barring bugs in libintl itself, this would not result in anything worse than failure to localize some early messages. Nonetheless, it's a bug, and an easy one to fix. Noted while investigating bug #17299 from Clemens Zeidler (much thanks to Liam Bowen for followup investigation on that). It currently appears that that actually *is* a bug in libintl itself, but that doesn't let us off the hook for this bit. Back-patch to all supported versions. Discussion: https://postgr.es/m/17299-7270741958c0b1ab@postgresql.org Discussion: https://postgr.es/m/CAE7q7Eit4Eq2=bxce=Fm8HAStECjaXUE=WBQc-sDDcgJQ7s7eg@mail.gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/37f5dc8b8cb4c3a58b0cc7df36378a1fdc7a8659 Modified Files -------------- src/interfaces/ecpg/ecpglib/misc.c | 11 +++++++++-- src/interfaces/libpq/fe-misc.c | 11 +++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-)
В списке pgsql-committers по дате отправления: