pgsql: Fix ruleutils.c's dumping of whole-row Vars in more contexts.
От | Tom Lane |
---|---|
Тема | pgsql: Fix ruleutils.c's dumping of whole-row Vars in more contexts. |
Дата | |
Msg-id | E1n88v0-0004uB-9j@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix ruleutils.c's dumping of whole-row Vars in more contexts. Commit 7745bc352 intended to ensure that whole-row Vars would be printed with "::type" decoration in all contexts where plain "var.*" notation would result in star-expansion, notably in ROW() and VALUES() constructs. However, it missed the case of INSERT with a single-row VALUES, as reported by Timur Khanjanov. Nosing around ruleutils.c, I found a second oversight: the code for RowCompareExpr generates ROW() notation without benefit of an actual RowExpr, and naturally it wasn't in sync :-(. (The code for FieldStore also does this, but we don't expect that to generate strictly parsable SQL anyway, so I left it alone.) Back-patch to all supported branches. Discussion: https://postgr.es/m/efaba6f9-4190-56be-8ff2-7a1674f9194f@intrans.baku.az Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3a1bfe256575bc1b9e9fd7c10a458084fedbd3a1 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 56 +++++++++++++++++++------------ src/test/regress/expected/create_view.out | 18 +++++++++- src/test/regress/sql/create_view.sql | 5 +++ 3 files changed, 56 insertions(+), 23 deletions(-)
В списке pgsql-committers по дате отправления: