pgsql: Remove assertion for replication origins in PREPARE TRANSACTION

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pgsql: Remove assertion for replication origins in PREPARE TRANSACTION
Дата
Msg-id E1mwx6C-0000WB-Ds@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Remove assertion for replication origins in PREPARE TRANSACTION

When using replication origins, pg_replication_origin_xact_setup() is an
optional choice to be able to set a LSN and a timestamp to mark the
origin, which would be additionally added to WAL for transaction commits
or aborts (including 2PC transactions).  An assertion in the code path
of PREPARE TRANSACTION assumed that this data should always be set, so
it would trigger when using replication origins without setting up an
origin LSN.  Some tests are added to cover more this kind of scenario.

Oversight in commit 1eb6d65.

Per discussion with Amit Kapila and Masahiko Sawada.

Discussion: https://postgr.es/m/YbbBfNSvMm5nIINV@paquier.xyz
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ece8c76192fee0b78509688325631ceabca44ff5

Modified Files
--------------
contrib/test_decoding/expected/replorigin.out | 76 +++++++++++++++++++++++++++
contrib/test_decoding/sql/replorigin.sql      | 32 +++++++++++
src/backend/access/transam/twophase.c         |  1 -
3 files changed, 108 insertions(+), 1 deletion(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: isolationtester: append session name to application_name.
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: isolationtester: append session name to application_name.