pgsql: Fix CREATE INDEX CONCURRENTLY for the newest prepared transactio
От | Noah Misch |
---|---|
Тема | pgsql: Fix CREATE INDEX CONCURRENTLY for the newest prepared transactio |
Дата | |
Msg-id | E1meSUe-0004X9-Nh@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix CREATE INDEX CONCURRENTLY for the newest prepared transactions. The purpose of commit 8a54e12a38d1545d249f1402f66c8cde2837d97c was to fix this, and it sufficed when the PREPARE TRANSACTION completed before the CIC looked for lock conflicts. Otherwise, things still broke. As before, in a cluster having used CIC while having enabled prepared transactions, queries that use the resulting index can silently fail to find rows. It may be necessary to reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices. Fix this for future index builds by making CIC wait for arbitrarily-recent prepared transactions and for ordinary transactions that may yet PREPARE TRANSACTION. As part of that, have PREPARE TRANSACTION transfer locks to its dummy PGPROC before it calls ProcArrayClearTransaction(). Back-patch to 9.6 (all supported versions). Andrey Borodin, reviewed (in earlier versions) by Andres Freund. Discussion: https://postgr.es/m/01824242-AA92-4FE9-9BA7-AEBAFFEA3D0C@yandex-team.ru Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5184932432b414478edebd74d13d4d16c7ca070c Modified Files -------------- src/backend/access/transam/twophase.c | 60 +++++++++- src/backend/access/transam/xact.c | 8 +- src/backend/storage/lmgr/lmgr.c | 7 +- src/backend/storage/lmgr/lock.c | 105 +++++++++++++---- src/backend/utils/cache/inval.c | 14 +++ src/bin/pgbench/t/023_cic_2pc.pl | 205 ++++++++++++++++++++++++++++++++++ src/include/access/twophase.h | 2 + src/include/storage/lock.h | 11 +- src/test/perl/PostgresNode.pm | 90 +++++++++++++++ 9 files changed, 466 insertions(+), 36 deletions(-)
В списке pgsql-committers по дате отправления: