Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.
CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
no later than each backend's next transaction start. That failed to
hold when a backend absorbed a relevant invalidation in the middle of
running RelationBuildDesc() on the CIC index. Queries that use the
resulting index can silently fail to find rows. Fix this for future
index builds by making RelationBuildDesc() loop until it finishes
without accepting a relevant invalidation. It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
Back-patch to 9.6 (all supported versions).
Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
Freund.
Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e428699cb3be0a7abbd5a83bfa5ec3e26c7fea84
Modified Files
--------------
src/backend/utils/cache/inval.c | 10 ++-
src/backend/utils/cache/relcache.c | 107 ++++++++++++++++++++++++-
src/bin/pgbench/t/022_cic.pl | 93 ++++++++++++++++++++++
src/include/utils/inval.h | 1 +
src/include/utils/relcache.h | 2 +-
src/test/perl/PostgresNode.pm | 155 +++++++++++++++++++++++++++++++++++++
src/test/perl/TestLib.pm | 43 ++++++++++
src/tools/pgindent/typedefs.list | 1 +
8 files changed, 408 insertions(+), 4 deletions(-)