pgsql: Repair two portability oversights of new test
От | Alvaro Herrera |
---|---|
Тема | pgsql: Repair two portability oversights of new test |
Дата | |
Msg-id | E1mVvk7-00066t-Qo@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Repair two portability oversights of new test First, as pointed out by Tom Lane and Michael Paquier, I failed to realize that Windows' PostgresNode needs an extra pg_hba.conf line (added by PostgresNode->set_replication_conf, called internally by ->init() when 'allows_streaming=>1' is given -- but I purposefully omitted that). I think a good fix should be to have nodes with only 'has_archiving=>1' set up for replication too, but that's a bigger discussion. Fix it by calling ->set_replication_conf, which is not unprecedented, as pointed out by Andrew Dunstan. I also forgot to uncomment a ->finish() call for a pumpable IPC::Run file descriptor. Apparently this is innocuous in almost all platforms. Backpatch to 14. The older branches were added this file too, but not this particular part of the test. Discussion: https://postgr.es/m/3000074.1632947632@sss.pgh.pa.us Discussion: https://postgr.es/m/YVT7qwhR8JmC2kfz@paquier.xyz Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d03bca4d70c29cca4f09e3a0e78a56cf97e237f3 Modified Files -------------- src/test/recovery/t/026_overwrite_contrecord.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
В списке pgsql-committers по дате отправления: