pgsql: Adjust MSVC build scripts to parse Makefiles for defines
От | David Rowley |
---|---|
Тема | pgsql: Adjust MSVC build scripts to parse Makefiles for defines |
Дата | |
Msg-id | E1m8tUg-0000ip-Me@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Adjust MSVC build scripts to parse Makefiles for defines This adjusts the MSVC build scripts to look at the compile flags mentioned in the Makefile to look for -D arguments in order to determine which constants should be defined in Visual Studio builds. One small anomaly that appeared as a result of this change is that the Makefile for the ltree contrib module defined LOWER_NODE, but this was not properly defined in the MSVC build scripts. This meant that MSVC builds would differ in case sensitivity in the ltree module when compared to builds using a make build environment. To maintain the same behavior here we remove the -DLOWER_NODE from the Makefile and just always define it in ltree.h for non-MSVC builds. We need to maintain the old behavior here as this affects the on-disk compatibility of GiST indexes when using the ltree type. The only other resulting change here is that REFINT_VERBOSE is now defined for the autoinc, insert_username and moddatetime contrib modules. Previously on MSVC, this was only defined for the refint module. This aligns the behavior to build environments using make as all 4 of these modules share the same Makefile. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/245de48455daaf51f2f3e8b198d87b5dd9fd4516 Modified Files -------------- contrib/ltree/Makefile | 1 - contrib/ltree/crc32.c | 1 + contrib/ltree/ltree.h | 13 +++++++++++++ src/tools/msvc/Mkvcbuild.pm | 21 ++++++++++++++++++++- 4 files changed, 34 insertions(+), 2 deletions(-)
В списке pgsql-committers по дате отправления: