pgsql: Fix unexpected error messages for various flavors of ALTER TABLE
От | Michael Paquier |
---|---|
Тема | pgsql: Fix unexpected error messages for various flavors of ALTER TABLE |
Дата | |
Msg-id | E1m3a48-0002gV-0B@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix unexpected error messages for various flavors of ALTER TABLE Some commands of ALTER TABLE could fail with the following error: ERROR: "tab" is of the wrong type This error is unexpected, as all the code paths leading to ATWrongRelkindError() should use a supported set of relkinds to generate correct error messages. This commit closes the gap with such mistakes, by adding all the missing relkind combinations. Tests are added to check all the problems found. Note that some combinations are not used, but these are left around as it could have an impact on applications relying on this code. 2ed532e has done a much larger refactoring on HEAD to make such error messages easier to manage in the long-term, so nothing is needed there. Author: Kyotaro Horiguchi Reviewed-by: Peter Eisentraut, Ahsan Hadi, Michael Paquier Discussion: https://postgr.es/m/20210216.181415.368926598204753659.horikyota.ntt@gmail.com Backpatch-through: 11 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0c83eb2e0edb42f54a37fdeac85fb80eb5de2cca Modified Files -------------- src/backend/commands/tablecmds.c | 9 +++++++++ src/test/regress/expected/alter_table.out | 10 ++++++++++ src/test/regress/expected/foreign_data.out | 2 ++ src/test/regress/sql/alter_table.sql | 9 +++++++++ src/test/regress/sql/foreign_data.sql | 1 + 5 files changed, 31 insertions(+)
В списке pgsql-committers по дате отправления: