pgsql: Remove libpq's use of abort(3) to handle mutex failure cases.
От | Tom Lane |
---|---|
Тема | pgsql: Remove libpq's use of abort(3) to handle mutex failure cases. |
Дата | |
Msg-id | E1lyFhs-0008To-Np@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Remove libpq's use of abort(3) to handle mutex failure cases. Doing an abort() seems all right in development builds, but not in production builds of general-purpose libraries. However, the functions that were doing this lack any way to report a failure back up to their callers. It seems like we can just get away with ignoring failures in production builds, since (a) no such failures have been reported in the dozen years that the code's been like this, and (b) failure to enforce mutual exclusion during fe-auth.c operations would likely not cause any problems anyway in most cases. (The OpenSSL callbacks that use this macro are obsolete, so even less likely to cause interesting problems.) Possibly a better answer would be to break compatibility of the pgthreadlock_t callback API, but in the absence of field problem reports, it doesn't really seem worth the trouble. Discussion: https://postgr.es/m/3131385.1624746109@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/aaddf6ba09e25878e792f0d15f725370e19396df Modified Files -------------- src/interfaces/libpq/fe-connect.c | 11 ++++++++--- src/interfaces/libpq/fe-secure-openssl.c | 9 +++++++-- src/interfaces/libpq/libpq-int.h | 7 ------- 3 files changed, 15 insertions(+), 12 deletions(-)
В списке pgsql-committers по дате отправления: