pgsql: Remove read_page callback from XLogReader.
От | Thomas Munro |
---|---|
Тема | pgsql: Remove read_page callback from XLogReader. |
Дата | |
Msg-id | E1lUSkg-0007xJ-CE@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Remove read_page callback from XLogReader. Previously, the XLogReader module would fetch new input data using a callback function. Redesign the interface so that it tells the caller to insert more data with a special return value instead. This API suits later patches for prefetching, encryption and maybe other future projects that would otherwise require continually extending the callback interface. As incidental cleanup work, move global variables readOff, readLen and readSegNo inside XlogReaderState. Author: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> Author: Heikki Linnakangas <hlinnaka@iki.fi> (parts of earlier version) Reviewed-by: Antonin Houska <ah@cybertec.at> Reviewed-by: Alvaro Herrera <alvherre@2ndquadrant.com> Reviewed-by: Takashi Menjo <takashi.menjo@gmail.com> Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20190418.210257.43726183.horiguchi.kyotaro%40lab.ntt.co.jp Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/323cbe7c7ddcf18aaf24b7f6d682a45a61d4e31b Modified Files -------------- src/backend/access/transam/twophase.c | 14 +- src/backend/access/transam/xlog.c | 126 ++-- src/backend/access/transam/xlogreader.c | 931 +++++++++++++++---------- src/backend/access/transam/xlogutils.c | 24 +- src/backend/replication/logical/logical.c | 26 +- src/backend/replication/logical/logicalfuncs.c | 13 +- src/backend/replication/slotfuncs.c | 18 +- src/backend/replication/walsender.c | 42 +- src/bin/pg_rewind/parsexlog.c | 107 +-- src/bin/pg_waldump/pg_waldump.c | 138 ++-- src/include/access/xlogreader.h | 153 ++-- src/include/access/xlogutils.h | 4 +- src/include/replication/logical.h | 11 +- 13 files changed, 930 insertions(+), 677 deletions(-)
В списке pgsql-committers по дате отправления: