pgsql: Fix ancient memory leak in contrib/auto_explain.
От | Tom Lane |
---|---|
Тема | pgsql: Fix ancient memory leak in contrib/auto_explain. |
Дата | |
Msg-id | E1l70jw-0000pc-Iy@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix ancient memory leak in contrib/auto_explain. The ExecutorEnd hook is invoked in a context that could be quite long-lived, not the executor's own per-query context as I think we were sort of assuming. Thus, any cruft generated while producing the EXPLAIN output could accumulate over multiple queries. This can result in spectacular leakage if log_nested_statements is on, and even without that I'm surprised nobody complained before. To fix, just switch into the executor's context so that anything we allocate will be released when standard_ExecutorEnd frees the executor state. We might as well nuke the code's retail pfree of the explain output string, too; that's laughably inadequate to the need. Japin Li, per report from Jeff Janes. This bug is old, so back-patch to all supported branches. Discussion: https://postgr.es/m/CAMkU=1wCVtbeRn0s9gt12KwQ7PLXovbpM8eg25SYocKW3BT4hg@mail.gmail.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2671125c75c04f7abc4a87998959c197e99e34c6 Modified Files -------------- contrib/auto_explain/auto_explain.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
В списке pgsql-committers по дате отправления: