pgsql: Revive "snapshot too old" with wal_level=minimal and SET TABLESP

Поиск
Список
Период
Сортировка
От Noah Misch
Тема pgsql: Revive "snapshot too old" with wal_level=minimal and SET TABLESP
Дата
Msg-id E1l5lkN-0004Zq-WB@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Revive "snapshot too old" with wal_level=minimal and SET TABLESPACE.

Given a permanent relation rewritten in the current transaction, the
old_snapshot_threshold mechanism assumed the relation had never been
subject to early pruning.  Hence, a query could fail to report "snapshot
too old" when the rewrite followed an early truncation.  ALTER TABLE SET
TABLESPACE is probably the only rewrite mechanism capable of exposing
this bug.  REINDEX sets indcheckxmin, avoiding the problem.  CLUSTER has
zeroed page LSNs since before old_snapshot_threshold existed, so
old_snapshot_threshold has never cooperated with it.  ALTER TABLE
... SET DATA TYPE makes the table look empty to every past snapshot,
which is strictly worse.  Back-patch to v13, where commit
c6b92041d38512a4176ed76ad06f713d2e6c01a8 broke this.

Kyotaro Horiguchi and Noah Misch

Discussion: https://postgr.es/m/20210113.160705.2225256954956139776.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7da83415e5bc01bba0093f34f4f612b70c70b678

Modified Files
--------------
src/backend/utils/time/snapmgr.c | 6 +++++-
src/include/utils/snapmgr.h      | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Fujii Masao
Дата:
Сообщение: pgsql: postgres_fdw: Fix tests for CLOBBER_CACHE_ALWAYS.
Следующее
От: Noah Misch
Дата:
Сообщение: pgsql: Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transact