pgsql: Optimize a few list_delete_ptr calls

Поиск
Список
Период
Сортировка
От David Rowley
Тема pgsql: Optimize a few list_delete_ptr calls
Дата
Msg-id E1kVPXP-0005e4-3E@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Optimize a few list_delete_ptr calls

There is a handful of places where we called list_delete_ptr() to remove
some element from a List.  In many of these places we know, or with very
little additional effort know the index of the ListCell that we need to
remove.

Here we change all of those places to instead either use one of;
list_delete_nth_cell(), foreach_delete_current() or list_delete_last().
Each of these saves from having to iterate over the list to search for the
element to remove by its pointer value.

There are some small performance gains to be had by doing this, but in the
general case, none of these lists are likely to be very large, so the
lookup was probably never that expensive anyway.  However, some of the
calls are in fairly hot code paths, e.g process_equivalence().  So any
small gains there are useful.

Author: Zhijie Hou and David Rowley
Discussion: https://postgr.es/m/b3517353ec7c4f87aa560678fbb1034b@G08CNEXMBPEKD05.g08.fujitsu.local

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e7c2b95d37a2b9c01367f7ccc55703555b39c81c

Modified Files
--------------
src/backend/optimizer/path/equivclass.c | 9 +++++++--
src/backend/optimizer/path/joinpath.c   | 4 ++--
src/backend/parser/parse_expr.c         | 5 +++--
src/backend/parser/parse_utilcmd.c      | 4 +++-
src/backend/rewrite/rewriteHandler.c    | 6 +-----
5 files changed, 16 insertions(+), 12 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix connection string handling in psql's \connect command.
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Use croak instead of die in Perl code when appropriate