pgsql: Remove complaints about COLLATE clauses in partition bound value
От | Tom Lane |
---|---|
Тема | pgsql: Remove complaints about COLLATE clauses in partition bound value |
Дата | |
Msg-id | E1kMxC7-0004Pu-Qx@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Remove complaints about COLLATE clauses in partition bound values. transformPartitionBoundValue went out of its way to do the wrong thing: there is no reason to complain about a non-matching COLLATE clause in a partition boundary expression. We're coercing the bound expression to the target column type as though by an implicit assignment, and the rules for implicit assignment say that collations can be implicitly converted. What we *do* need to do, and the code is not doing, is apply assign_expr_collations() to the bound expression. While this is merely a definition disagreement, that is a bug that needs to be back-patched, so I'll commit it separately. Discussion: https://postgr.es/m/CAJV4CdrZ5mKuaEsRSbLf2URQ3h6iMtKD=hik8MaF5WwdmC9uZw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2dfa3fea88bc951d0812a18649d801f07964c9b9 Modified Files -------------- src/backend/parser/parse_utilcmd.c | 44 ------------------------------ src/test/regress/expected/create_table.out | 32 ++++++++++------------ src/test/regress/sql/create_table.sql | 18 ++++-------- 3 files changed, 21 insertions(+), 73 deletions(-)
В списке pgsql-committers по дате отправления: