pgsql: Avoid trying to restore table ACLs and per-column ACLs in parall
От | Tom Lane |
---|---|
Тема | pgsql: Avoid trying to restore table ACLs and per-column ACLs in parall |
Дата | |
Msg-id | E1juJRB-0007Ps-PU@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Avoid trying to restore table ACLs and per-column ACLs in parallel. Parallel pg_restore has always supposed that ACL items for different objects are independent and can be restored in parallel without conflicts. However, there is one case where this fails: because REVOKE on a table is defined to also revoke the privilege(s) at column level, we can't restore per-column ACLs till after we restore any table-level privileges on their table. Failure to honor this restriction can lead to "tuple concurrently updated" errors during parallel restore, or even to the per-column ACLs silently disappearing because the table-level REVOKE is executed afterwards. To fix, add a dependency from each column-level ACL item to its table's ACL item, if there is one. Note that this doesn't fix the hazard for pre-existing archive files, only for ones made with a corrected pg_dump. Given that the bug's been there quite awhile without field reports, I think this is acceptable. This requires changing the API of pg_dump's dumpACL() function. To keep its argument list from getting even longer, I removed the "CatalogId objCatId" argument, which has been unused for ages. Per report from Justin Pryzby. Back-patch to all supported branches. Discussion: https://postgr.es/m/20200706050129.GW4107@telsasoft.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5fea14f4b2c5ca4e4d9def92b17e50fcfbaf3468 Modified Files -------------- src/bin/pg_dump/common.c | 2 +- src/bin/pg_dump/pg_backup.h | 6 +++ src/bin/pg_dump/pg_dump.c | 91 ++++++++++++++++++++++++++++----------------- 3 files changed, 64 insertions(+), 35 deletions(-)
В списке pgsql-committers по дате отправления: