pgsql: Avoid low-probability regression test failures in timestamp[tz]
От | Tom Lane |
---|---|
Тема | pgsql: Avoid low-probability regression test failures in timestamp[tz] |
Дата | |
Msg-id | E1ijADb-00082g-6D@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Avoid low-probability regression test failures in timestamp[tz] tests. If the first transaction block in these tests were entered exactly at midnight (California time), they'd report a bogus failure due to 'now' and 'midnight' having the same values. Commit 8c2ac75c5 had dismissed this as being of negligible probability, but we've now seen it happen in the buildfarm, so let's prevent it. We can get pretty much the same test coverage without an it's-not-midnight assumption by moving the does-'now'-work cases into their own test step. While here, apply commit 47169c255's s/DELETE/TRUNCATE/ change to timestamptz as well as timestamp (not sure why that didn't occur to me at the time; the risk of failure is the same). Back-patch to all supported branches, since the main point is to get rid of potential buildfarm failures. Discussion: https://postgr.es/m/14821.1577031117@sss.pgh.pa.us Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8f735c0488c68d02ed9a484851277fd5df4570c5 Modified Files -------------- src/test/regress/expected/timestamp.out | 39 ++++++++++++++--------------- src/test/regress/expected/timestamptz.out | 41 +++++++++++++++++++------------ src/test/regress/sql/timestamp.sql | 22 ++++++++--------- src/test/regress/sql/timestamptz.sql | 24 +++++++++--------- 4 files changed, 65 insertions(+), 61 deletions(-)
В списке pgsql-committers по дате отправления: