pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST
| От | Alexander Korotkov |
|---|---|
| Тема | pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST |
| Дата | |
| Msg-id | E1iB1pb-00075a-Dx@gemulon.postgresql.org обсуждение исходный текст |
| Ответы |
Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST
|
| Список | pgsql-committers |
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOrderByDistance struct. Alignment overhead should be negligible, because we typically deal with at most few "col op const" expressions in ORDER BY clause. * It fixes handling of "col op NULL" expression in KNN-SP-GiST. Now, these expression are not passed to support functions, which can't deal with them. Instead, NULL result is implicitly assumed. It future we may decide to teach support functions to deal with NULL arguments, but current solution is bugfix suitable for backpatch. Reported-by: Nikita Glukhov Discussion: https://postgr.es/m/826f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6cae9d2c10e151f741e7bc64a8b70bb2615c367c Modified Files -------------- src/backend/access/gist/gistget.c | 68 ++++++++------------- src/backend/access/gist/gistscan.c | 16 ++--- src/backend/access/index/indexam.c | 22 +++---- src/backend/access/spgist/spgscan.c | 74 +++++++++++++++++++---- src/include/access/genam.h | 10 ++- src/include/access/gist_private.h | 27 ++------- src/include/access/spgist_private.h | 8 ++- src/test/regress/expected/create_index_spgist.out | 10 +++ src/test/regress/sql/create_index_spgist.sql | 5 ++ src/tools/pgindent/typedefs.list | 1 + 10 files changed, 140 insertions(+), 101 deletions(-)
В списке pgsql-committers по дате отправления: