pgsql: Fix error handling of vacuumdb and reindexdb when running outof
От | Michael Paquier |
---|---|
Тема | pgsql: Fix error handling of vacuumdb and reindexdb when running outof |
Дата | |
Msg-id | E1i24Z8-0004EZ-Jj@gemulon.postgresql.org обсуждение исходный текст |
Ответы |
Re: pgsql: Fix error handling of vacuumdb and reindexdb when runningout of
|
Список | pgsql-committers |
Fix error handling of vacuumdb and reindexdb when running out of fds When trying to use a high number of jobs, vacuumdb (and more recently reindexdb) has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error handling so as we do not check anymore for a maximum number of allowed jobs when parsing the option value with FD_SETSIZE, but check instead if a file descriptor is within the supported range when opening the connections for the jobs so as this is detected at the earliest time possible. Also, improve the error message to give a hint about the number of jobs recommended, using a wording given by the reviewers of the patch. Reported-by: Andres Freund Author: Michael Paquier Reviewed-by: Andres Freund, Álvaro Herrera, Tom Lane Discussion: https://postgr.es/m/20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de Backpatch-through: 9.5 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/71d84efba714db3b8a330a54be15c4d385719ad6 Modified Files -------------- src/bin/scripts/reindexdb.c | 6 ------ src/bin/scripts/scripts_parallel.c | 26 ++++++++++++-------------- src/bin/scripts/scripts_parallel.h | 2 -- src/bin/scripts/vacuumdb.c | 6 ------ 4 files changed, 12 insertions(+), 28 deletions(-)
В списке pgsql-committers по дате отправления: