pgsql: Fix inconsistencies and typos in the tree

Fix inconsistencies and typos in the tree

This is numbered take 8, and addresses again a set of issues with code
comments, variable names and unreferenced variables.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/b137b5eb-9c95-9c2f-586e-38aba7d59788@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb43f3d19324d7e5376b1f57fc2e5c142a6b5f3d

Modified Files
--------------
contrib/pgcrypto/pgp-decrypt.c          |  2 +-
doc/src/sgml/custom-scan.sgml           |  5 +----
doc/src/sgml/ref/create_aggregate.sgml  |  2 +-
doc/src/sgml/xplang.sgml                |  2 +-
src/Makefile.global.in                  |  2 +-
src/backend/access/common/bufmask.c     |  2 +-
src/backend/access/gin/gindatapage.c    |  2 +-
src/backend/access/heap/rewriteheap.c   |  4 ++--
src/backend/access/spgist/spgvacuum.c   |  2 +-
src/backend/access/transam/xact.c       |  2 +-
src/backend/access/transam/xlog.c       | 15 +++++++++------
src/backend/catalog/pg_aggregate.c      |  2 +-
src/backend/commands/dbcommands.c       |  2 +-
src/backend/commands/operatorcmds.c     |  3 ---
src/backend/libpq/auth.c                | 11 +++--------
src/backend/postmaster/bgwriter.c       |  8 ++++----
src/backend/replication/walsender.c     |  4 ++--
src/backend/storage/ipc/procarray.c     |  2 +-
src/backend/storage/ipc/standby.c       |  2 +-
src/backend/storage/lmgr/lwlock.c       |  2 +-
src/backend/storage/smgr/md.c           |  2 +-
src/backend/tcop/pquery.c               |  4 ++--
src/backend/utils/adt/arrayfuncs.c      |  2 +-
src/backend/utils/adt/like_match.c      |  3 ++-
src/backend/utils/mmgr/aset.c           |  2 +-
src/bin/initdb/initdb.c                 |  2 +-
src/bin/pg_controldata/pg_controldata.c |  2 +-
src/bin/pg_ctl/pg_ctl.c                 |  2 +-
src/bin/pg_upgrade/pg_upgrade.h         |  3 ---
src/bin/pgevent/README                  |  2 +-
src/common/unicode_norm.c               |  2 +-
src/include/access/gist_private.h       |  2 +-
src/include/commands/dbcommands.h       |  2 +-
src/include/replication/logicalproto.h  |  6 +++---
src/include/statistics/statistics.h     |  2 +-
src/include/storage/bufpage.h           |  2 +-
src/include/storage/lock.h              |  2 +-
src/include/storage/lockdefs.h          |  2 +-
src/include/storage/lwlock.h            |  2 +-
src/interfaces/libpq/fe-exec.c          |  2 +-
src/pl/plperl/plperl.c                  |  2 +-
src/tools/FAQ2txt                       |  7 -------
42 files changed, 58 insertions(+), 75 deletions(-)