pgsql: Fix inconsistencies and typos in the tree

Fix inconsistencies and typos in the tree

This is numbered take 7, and addresses a set of issues around:
- Fixes for typos and incorrect reference names.
- Removal of unneeded comments.
- Removal of unreferenced functions and structures.
- Fixes regarding variable name consistency.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/10bfd4ac-3e7c-40ab-2b2e-355ed15495e8@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0896ae561b6c799d45cb61d8a3b18fbb442130a7

Modified Files
--------------
contrib/cube/cube.c                        |  2 +-
contrib/intarray/_int.h                    |  6 ------
contrib/ltree/ltxtquery_io.c               |  2 +-
contrib/pgstattuple/pgstatindex.c          |  2 +-
doc/src/sgml/gist.sgml                     |  2 +-
src/backend/access/gin/README              |  2 +-
src/backend/access/gin/ginfast.c           |  2 +-
src/backend/access/gist/README             |  2 +-
src/backend/access/gist/gist.c             |  2 +-
src/backend/access/nbtree/README           |  2 +-
src/backend/access/spgist/spgscan.c        |  5 -----
src/backend/access/transam/clog.c          |  2 +-
src/backend/bootstrap/bootstrap.c          |  2 +-
src/backend/catalog/namespace.c            |  2 +-
src/backend/executor/nodeAgg.c             |  2 +-
src/backend/optimizer/prep/prepunion.c     |  4 ++--
src/backend/parser/parse_agg.c             |  2 +-
src/backend/rewrite/rewriteManip.c         |  2 +-
src/backend/storage/buffer/bufmgr.c        |  5 +++--
src/backend/storage/file/buffile.c         |  2 +-
src/backend/storage/file/fd.c              |  2 +-
src/backend/storage/freespace/freespace.c  |  4 ++--
src/backend/storage/lmgr/lock.c            | 12 ++++++------
src/backend/storage/lmgr/predicate.c       |  6 +++---
src/backend/utils/adt/formatting.c         |  2 --
src/backend/utils/adt/inet_cidr_ntop.c     |  2 +-
src/backend/utils/adt/ruleutils.c          | 18 +++++++++---------
src/backend/utils/mmgr/dsa.c               |  4 ++--
src/bin/pg_dump/pg_dump.c                  |  4 +---
src/bin/pg_dump/pg_dump.h                  |  3 ---
src/bin/pg_upgrade/pg_upgrade.c            |  2 +-
src/include/access/gist_private.h          |  2 +-
src/include/access/xlog_internal.h         |  2 +-
src/include/foreign/foreign.h              | 11 -----------
src/include/postmaster/postmaster.h        |  1 -
src/include/storage/fsm_internals.h        |  2 +-
src/include/storage/predicate_internals.h  |  2 +-
src/interfaces/ecpg/compatlib/informix.c   |  2 +-
src/interfaces/ecpg/pgtypeslib/dt_common.c |  2 +-
src/port/thread.c                          |  2 +-
src/test/perl/TestLib.pm                   |  2 +-
41 files changed, 55 insertions(+), 84 deletions(-)