pgsql: Move pattern selectivity code from selfuncs.c tolike_support.c.
От | Tom Lane |
---|---|
Тема | pgsql: Move pattern selectivity code from selfuncs.c tolike_support.c. |
Дата | |
Msg-id | E1guJJ2-0005UI-6t@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Move pattern selectivity code from selfuncs.c to like_support.c. While at it, refactor patternsel() a bit so that it can be used from the LIKE/regex planner support functions as well. This makes the planner able to deal equally well with either operator or function syntax for these operations. I'm not excited about that as a feature in itself, but it provides a nice model for extensions to follow if they want such behavior for their operations. This change localizes the use of pattern_fixed_prefix() and make_greater_string() so that they no longer need be exported. (We might get pushback from extensions about that, perhaps, in which case I'd be inclined to re-export them in a new header file like_support.h.) This reduces the bulk of selfuncs.c a fair amount, removing ~1370 lines or about one-sixth of that file; it's still too big, but this is progress. Discussion: https://postgr.es/m/24537.1550093915@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/49fa99e54ec0ded180b52a4a14e543702d53e8c9 Modified Files -------------- src/backend/utils/adt/like_support.c | 1414 +++++++++++++++++++++++++++++++++- src/backend/utils/adt/selfuncs.c | 1381 +-------------------------------- src/include/utils/selfuncs.h | 33 +- 3 files changed, 1455 insertions(+), 1373 deletions(-)
В списке pgsql-committers по дате отправления: