pgsql: Fix pg_get_indexdef()'s behavior for included index columns.
От | Tom Lane |
---|---|
Тема | pgsql: Fix pg_get_indexdef()'s behavior for included index columns. |
Дата | |
Msg-id | E1fgE44-0005an-QR@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix pg_get_indexdef()'s behavior for included index columns. The multi-argument form of pg_get_indexdef() failed to print anything when asked to print a single index column that is an included column rather than a key column. This seems an unintentional result of someone having tried to take a short-cut and use the attrsOnly flag for two different purposes. To fix, split said flag into two flags, attrsOnly which suppresses non-attribute info, and keysOnly which suppresses included columns. Add a test case using psql's \d command, which relies on that function. (It's mighty tempting at this point to replace pg_get_indexdef_worker's mess of boolean flag arguments with a single bitmask-of-flags argument, which would allow making the call sites much more self-documenting. But I refrained for the moment.) Discussion: https://postgr.es/m/21724.1531943735@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/028e3da2949482fa56f3ffdbda840782f2953b0b Modified Files -------------- src/backend/utils/adt/ruleutils.c | 45 ++++++++++++++++----------- src/test/regress/expected/index_including.out | 10 ++++++ src/test/regress/sql/index_including.sql | 1 + 3 files changed, 38 insertions(+), 18 deletions(-)
В списке pgsql-committers по дате отправления: