pgsql: Arrange to supply declarations for strtoll/strtoull if needed.
От | Tom Lane |
---|---|
Тема | pgsql: Arrange to supply declarations for strtoll/strtoull if needed. |
Дата | |
Msg-id | E1fJrpL-00007P-AQ@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations of strtoll/strtoull in C89-compliant builds. (I find it pretty curious that they hide those function declarations when you can nonetheless declare a "long long" variable, but anyway that is their behavior, both on dromedary's obsolete macOS version and the newest and shiniest.) As a result, gcc assumes these functions return "int", leading naturally to wrong results. (Looking at dromedary's past build results, it's evident that this problem also breaks pg_strtouint64() on 32-bit platforms; but we evidently have no regression tests that exercise that function with values above 32 bits.) To fix, supply declarations for these functions when the platform provides the functions but not the declarations, using the same type of mechanism as we use for some other similar cases. Discussion: https://postgr.es/m/151935568942.1461.14623890240535309745@wrigleys.postgresql.org Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/023aa76e19529bf3f00f1815262fc78186c01636 Modified Files -------------- configure | 22 ++++++++++++++++++++++ configure.in | 2 ++ src/include/c.h | 8 ++++++++ src/include/pg_config.h.in | 8 ++++++++ src/include/pg_config.h.win32 | 8 ++++++++ 5 files changed, 48 insertions(+)
В списке pgsql-committers по дате отправления: