pgsql: Refactor subscription tests to use PostgresNode'swait_for_catch

Refactor subscription tests to use PostgresNode's wait_for_catchup

This was nearly the same code.  Extend wait_for_catchup to allow waiting
for pg_current_wal_lsn() and use that in the subscription tests.  Also
change one use in the pg_rewind tests to use this.

Also remove some broken code in wait_for_catchup and
wait_for_slot_catchup.  The error message in case the waiting failed
wanted to show the current LSN, but the way it was written never
worked.  So since nobody ever cared, just remove it.

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bbd3363e128daec0e70952c1bb2f12ab1f6f1292

Modified Files
--------------
src/bin/pg_rewind/RewindTest.pm            |  5 +----
src/test/perl/PostgresNode.pm              | 22 +++++++++++++++-------
src/test/subscription/t/001_rep_changes.pl | 19 +++++--------------
src/test/subscription/t/002_types.pl       | 15 ++++-----------
src/test/subscription/t/003_constraints.pl | 15 ++++-----------
src/test/subscription/t/004_sync.pl        | 14 +++-----------
src/test/subscription/t/005_encoding.pl    | 13 ++-----------
src/test/subscription/t/006_rewrite.pl     | 17 ++++-------------
src/test/subscription/t/007_ddl.pl         | 11 +----------
src/test/subscription/t/008_diff_schema.pl | 15 +++------------
10 files changed, 42 insertions(+), 104 deletions(-)