pgsql: Fix handling of NULLs returned by aggregate combine functions.
От | Andres Freund |
---|---|
Тема | pgsql: Fix handling of NULLs returned by aggregate combine functions. |
Дата | |
Msg-id | E1eI2eD-0008JT-SM@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix handling of NULLs returned by aggregate combine functions. When strict aggregate combine functions, used in multi-stage/parallel aggregation, returned NULL, we didn't check for that, invoking the combine function with NULL the next round, despite it being strict. The equivalent code invoking normal transition functions has a check for that situation, which did not get copied in a7de3dc5c346. Fix the bug by adding the equivalent check. Based on a quick look I could not find any strict combine functions in core actually returning NULL, and it doesn't seem very likely external users have done so. So this isn't likely to have caused issues in practice. Add tests verifying transition / combine functions returning NULL is tested. Reported-By: Andres Freund Author: Andres Freund Discussion: https://postgr.es/m/20171121033642.7xvmjqrl4jdaaat3@alap3.anarazel.de Backpatch: 9.6, where parallel aggregation was introduced Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c60b898453f9b4d7de94c8e88bf08e930d117958 Modified Files -------------- src/backend/executor/nodeAgg.c | 11 +++++ src/test/regress/expected/aggregates.out | 71 ++++++++++++++++++++++++++++++++ src/test/regress/sql/aggregates.sql | 63 ++++++++++++++++++++++++++++ 3 files changed, 145 insertions(+)
В списке pgsql-committers по дате отправления: