[COMMITTERS] pgsql: Fix record length computation in pg_waldump/xlogdump.

Поиск
Список
Период
Сортировка
От Andres Freund
Тема [COMMITTERS] pgsql: Fix record length computation in pg_waldump/xlogdump.
Дата
Msg-id E1dI1AG-00017A-0v@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix record length computation in pg_waldump/xlogdump.

The current method of computing the record length (excluding the
lenght of full-page images) has been wrong since the WAL format has
been revamped in 2c03216d831160bedd72d45f712601b6f7d03f1c.  Only the
main record's length was counted, but that can be significantly too
little if there's data associated with further blocks.

Fix by computing the record length as total_lenght - fpi_length.

Reported-By: Chen Huajun
Bug: #14687
Reviewed-By: Heikki Linnakangas
Discussion: https://postgr.es/m/20170603165939.1436.58887@wrigleys.postgresql.org
Backpatch: 9.5-

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c25ed20067d21a97242a023031fcdcc232d6945c

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 49 ++++++++++++++++++++++++++++-------------
1 file changed, 34 insertions(+), 15 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: [COMMITTERS] pgsql: Code review for shm_toc.h/.c.
Следующее
От: Andres Freund
Дата:
Сообщение: [COMMITTERS] pgsql: Fix record length computation in pg_waldump/xlogdump.