[COMMITTERS] pgsql: Fix minor oversights in nodeAgg.c.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема [COMMITTERS] pgsql: Fix minor oversights in nodeAgg.c.
Дата
Msg-id E1cJUfY-0007YS-6l@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix minor oversights in nodeAgg.c.

aggstate->evalproj is always set up by ExecInitAgg, so there's no
need to test.  Doing so led Coverity to think that we might be
intending "slot" to be possibly NULL here, and it quite properly
complained that the rest of combine_aggregates() wasn't prepared
for that.

Also fix a couple of obvious thinkos in Asserts checking that
"inputoff" isn't past the end of the slot.

Errors introduced in commit 8ed3f11bb, so no need for back-patch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c080b223a7a3991524a5287416a0ad756c15a098

Modified Files
--------------
src/backend/executor/nodeAgg.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: [COMMITTERS] pgsql: Fix minor error message style violation.
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Simplify LWLock tranche machinery by removing array_base/array_s